Messages in this thread | | | Date | Mon, 1 Jun 2009 20:46:58 +0800 | From | Wu Fengguang <> | Subject | Re: [PATCH] [13/16] HWPOISON: The high level memory error handler in the VM v4 |
| |
On Mon, Jun 01, 2009 at 07:16:41PM +0800, Nick Piggin wrote: > On Fri, May 29, 2009 at 11:35:39PM +0200, Andi Kleen wrote: > > + mapping = page_mapping(p); > > + if (!PageDirty(p) && !PageWriteback(p) && > > + !PageAnon(p) && !PageSwapBacked(p) && > > + mapping && mapping_cap_account_dirty(mapping)) { > > Haven't had another good look at this yet, but if you hold the > page locked, and have done a wait_on_page_writeback, then > PageWriteback == true is a kernel bug.
Right, we can eliminate the PageWriteback() test when there is a wait_on_page_writeback().
| |