lkml.org 
[lkml]   [2009]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/18] ide: dequeue in-flight request
    On Fri, May 08, 2009 at 11:53:59AM +0900, Tejun Heo wrote:
    > ide generally has single request in flight and tracks it using
    > hwif->rq and all state handlers follow the following convention.
    >
    > * ide_started is returned if the request is in flight.
    >
    > * ide_stopped is returned if the queue needs to be restarted. The
    > request might or might not have been processed fully or partially.
    >
    > * hwif->rq is set to NULL, when an issued request completes.
    >
    > So, dequeueing model can be implemented by dequeueing after fetch,
    > requeueing if hwif->rq isn't NULL on ide_stopped return and doing
    > about the same thing on completion / port unlock paths. These changes
    > can be made in ide-io proper.
    >
    > In addition to the above main changes, the following updates are
    > necessary.
    >
    > * ide-cd shouldn't dequeue a request when issuing REQUEST SENSE for it
    > as the request is already dequeued.
    >
    > * ide-atapi uses request queue as stack when issuing REQUEST SENSE to
    > put the REQUEST SENSE in front of the failed request. This now
    > needs to be done using requeueing.
    >
    > [ Impact: dequeue in-flight request ]
    >
    > Signed-off-by: Tejun Heo <tj@kernel.org>
    > Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    > Cc: Borislav Petkov <petkovbb@googlemail.com>
    > Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>

    Acked-by: Borislav Petkov <petkovbb@gmail.com>

    --
    Regards/Gruss,
    Boris.


    \
     
     \ /
      Last update: 2009-05-09 08:59    [W:4.199 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site