Messages in this thread | | | Date | Fri, 08 May 2009 22:25:03 +0200 | From | Jiri Slaby <> | Subject | Re: [PATCH] staging/wlan-ng: Change KERN_DEBUG or pr_debug to match orig driver |
| |
On 05/08/2009 09:54 PM, Karl Relton wrote: > Change uses of KERN_DEBUG over to pr_debug to match original driver > where messages are only needed during driver development.
Hmm, but many of them don't fit this rule. Some of them should be honored a higher level, some of them simply should be left as such, because we want to see the information.
> --- c/drivers/staging/wlan-ng/prism2mgmt.c 2009-04-30 05:48:16.000000000 +0100 > +++ d/drivers/staging/wlan-ng/prism2mgmt.c 2009-05-08 19:11:11.000000000 +0100 > @@ -1096,7 +1096,7 @@ int prism2mgmt_wlansniff(wlandevice_t *w > /* Disable monitor mode */ > result = hfa384x_cmd_monitor(hw, HFA384x_MONITOR_DISABLE); > if (result) { > - printk(KERN_DEBUG > + pr_debug( > "failed to disable monitor mode, result=%d\n",
rather an ERROR or WARNING?
> --- c/drivers/staging/wlan-ng/prism2sta.c 2009-04-30 05:48:16.000000000 +0100 > +++ d/drivers/staging/wlan-ng/prism2sta.c 2009-05-08 19:15:08.000000000 +0100 > @@ -1188,7 +1188,7 @@ static void prism2sta_inf_chinforesults( > chinforesult->active = > le16_to_cpu(inf->info.chinforesult.result[n]. > active); > - printk(KERN_DEBUG > + pr_debug( > "chinfo: channel %d, %s level (avg/peak)=%d/%d dB, pcf %d\n",
yeah, useless info for an user (the change is OK), but:
> @@ -1276,7 +1276,7 @@ void prism2sta_processing_defer(struct w > wlandev->bssid, > WLAN_BSSID_LEN); > if (result) { > - printk(KERN_DEBUG > + pr_debug( > "getconfig(0x%02x) failed, result = %d\n", > HFA384x_RID_CURRENTBSSID, result);
we want likely to know this one.
etc.
| |