Messages in this thread | | | Date | Fri, 8 May 2009 21:11:01 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH] x86 MCE: shut up lockdep warning |
| |
> So was this a genuine bug in your code? The patch suggests it was.
No I think it was false. See my earlier email.
The higher level cpu_add_remove_lock makes sure that there is never an interrupt when the code is running process context.
So Ingo's patch shuts off lockdep, but it's overkill and not really needed. It would be better if there was some way to express the dependency on cpu_add_remove_lock, but I'm not sure that can be expressed in lockdep.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |