lkml.org 
[lkml]   [2009]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/15] ps3vram: Use proc_create_data() instead of proc_create()
    Date
    Use proc_create_data() to avoid race conditions.

    Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
    Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
    Cc: Jim Paris <jim@jtan.com>
    ---
    drivers/block/ps3vram.c | 8 +++-----
    1 files changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c
    index 2e79d2c..6e73868 100644
    --- a/drivers/block/ps3vram.c
    +++ b/drivers/block/ps3vram.c
    @@ -546,12 +546,10 @@ static void __devinit ps3vram_proc_init(struct ps3_system_bus_device *dev)
    struct ps3vram_priv *priv = dev->core.driver_data;
    struct proc_dir_entry *pde;

    - pde = proc_create(DEVICE_NAME, 0444, NULL, &ps3vram_proc_fops);
    - if (!pde) {
    + pde = proc_create_data(DEVICE_NAME, 0444, NULL, &ps3vram_proc_fops,
    + priv);
    + if (!pde)
    dev_warn(&dev->core, "failed to create /proc entry\n");
    - return;
    - }
    - pde->data = priv;
    }

    static int ps3vram_make_request(struct request_queue *q, struct bio *bio)
    --
    1.6.2.4


    \
     
     \ /
      Last update: 2009-05-08 16:05    [W:0.021 / U:29.888 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site