Messages in this thread | | | Date | Fri, 8 May 2009 08:44:05 -0400 | From | Vivek Goyal <> | Subject | Re: [PATCH 17/18] io-controller: IO group refcounting support |
| |
On Fri, May 08, 2009 at 10:59:31AM +0800, Gui Jianfeng wrote: > Vivek Goyal wrote: > ... > > > > - BUG_ON(!RB_EMPTY_ROOT(&st->active)); > > - BUG_ON(!RB_EMPTY_ROOT(&st->idle)); > > } > > > > - BUG_ON(iog->sched_data.next_active != NULL); > > - BUG_ON(iog->sched_data.active_entity != NULL); > > - BUG_ON(entity->tree != NULL); > > + /* Drop iocg reference on io group */ > > We'd better to reset iog->iocg_id here since the cgroup is going to destroy. >
Hm.., that does not harm. Will do in next version.
Thanks Vivek
| |