lkml.org 
[lkml]   [2009]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 3/3a] ptrace: add _ptrace_may_access()
* Ingo Molnar (mingo@elte.hu) wrote:
>
> * Chris Wright <chrisw@sous-sol.org> wrote:
>
> > * Ingo Molnar (mingo@elte.hu) wrote:
> > > * Oleg Nesterov <oleg@redhat.com> wrote:
> > > > Agreed, but what about security_operations->ptrace_may_access ?
> > > > It has the same (bad) name, but returns the error code or 0 on
> > > > success.
> > >
> > > Bad code should generally be fixed, or in exceptional circumstances
> > > it can tolerated if it's pre-existing bad code, but it should never
> > > be propagated. It has not spread _that_ widely yet, and is isolated
> > > to the security subsystem:
> >
> > And the security hooks tend to all follow the 0 success -ve ERR on error.
>
> I just sent a patch (see below) that renames them to
> ptrace_access_check().
>
> They have no active connection to the core kernel
> ptrace_may_access() check in any case:

Not sure what you mean:

ptrace_may_access
__ptrace_may_access
security_ptrace_may_access

Looks like your patch won't compile.



\
 
 \ /
  Last update: 2009-05-07 11:25    [W:0.138 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site