lkml.org 
[lkml]   [2009]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] tracing/events: add rcu locking around trace event prints

On Thu, 7 May 2009, Ingo Molnar wrote:

>
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > Somehow this patch got dropped. I believe Ted's work requires it.
> >
> > I'm not sure if we need to include rcupdate.h or not to use
> > rcu_read_lock. I think it may be fine to include it in ftrace.h.
> >
> > Jeremy, does this patch effect anything that you are doing?
> >
> > > \
> > > + rcu_read_lock(); \
> > > ret = trace_seq_printf(s, #call ": " print); \
> > > + rcu_read_unlock(); \
> > > if (!ret) \
> > > return TRACE_TYPE_PARTIAL_LINE; \
>
> Hm, this patch adds usage for RCU primitives, but doesnt include
> rcupdate.h.

Yeah, I thought that would be an issue. Including rcupdate here should not
be an issue, since the ftrace.h file is only included once, and the
CREATE_TRACE_POINTS is already undefined.

I'll write up a new patch.

Thanks,

-- Steve



\
 
 \ /
  Last update: 2009-05-07 15:13    [W:0.051 / U:22.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site