| | From | "Rafael J. Wysocki" <> | | Subject | Re: [RFC][PATCH 1/5] PM/Freezer: Disable OOM killer when tasks are frozen | | Date | Thu, 7 May 2009 14:10:37 +0200 |
| |
On Thursday 07 May 2009, Nigel Cunningham wrote: > Hi.
Hi,
> On Thu, 2009-05-07 at 00:41 +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rjw@sisk.pl> > > > > The OOM killer is not really going to work while tasks are frozen, so > > we can just give up calling it in that case. > > > > This will allow us to safely use memory allocations for decreasing > > the number of saveable pages in the hibernation core code instead of > > using any artificial memory shriking mechanisms for this purpose. > > Should we disable the warning that the nopage path gives if tasks are > frozen? I'm in two minds - if you get problems as a result, it might > help to diagnose them. On the other hand, you don't want tons of > warnings due to the hibernation code trying to allocate memory it can't > get. In TuxOnIce, I currently do all allocations with __GFP_NOWARN.
Yes, I use __GFP_NOWARN in the next patches too. :-)
Thanks, Rafael
|