lkml.org 
[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] ptrace: cleanup check/set of PT_PTRACED during attach

* Oleg Nesterov <oleg@redhat.com> wrote:

> ptrace_attach() and ptrace_traceme() are the last functions which
> look as if the untraced task can have task->ptrace != 0, this must
> not be possible. Change the code to just check ->ptrace != 0 and
> s/|=/=/ to set PT_PTRACED.
>
> Also, a couple of trivial whitespace cleanups in ptrace_attach().
>
> And move ptrace_traceme() up near ptrace_attach() to keep them
> close to each other.

btw., while at it, please also fix the typos in
include/linux/ptrace.h's PT_* flags section:

/*
* Ptrace flags
*
* The owner ship rules for task->ptrace which holds the ptrace
* flags is simple. When a task is running it owns it's task->ptrace
* flags. When the a task is stopped the ptracer owns task->ptrace.
*/
s/owner ship/ownership
s/it's/its

Thanks,

Ingo


\
 
 \ /
  Last update: 2009-05-06 09:49    [from the cache]
©2003-2011 Jasper Spaans