Messages in this thread Patch in this message | | | Date | Wed, 06 May 2009 14:45:47 -0700 | From | Greg KH <> | Subject | [patch 19/58] unreached code in selinux_ip_postroute_iptables_compat() (CVE-2009-1184) |
| |
2.6.29-stable review patch. If anyone has any objections, please let us know.
------------------
From: Eugene Teo <eteo@redhat.com>
Not upstream in 2.6.30, as the function was removed there, making this a non-issue.
Node and port send checks can skip in the compat_net=1 case. This bug was introduced in commit effad8d.
Signed-off-by: Eugene Teo <eugeneteo@kernel.sg> Reported-by: Dan Carpenter <error27@gmail.com> Acked-by: James Morris <jmorris@namei.org> Acked-by: Paul Moore <paul.moore@hp.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- security/selinux/hooks.c | 1 + 1 file changed, 1 insertion(+)
--- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -4661,6 +4661,7 @@ static int selinux_ip_postroute_iptables if (err) return err; err = avc_has_perm(sk_sid, if_sid, SECCLASS_NETIF, netif_perm, ad); + if (err) return err; err = sel_netnode_sid(addrp, family, &node_sid);
| |