lkml.org 
[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/6] ksm: change the KSM_REMOVE_MEMORY_REGION ioctl.
    * Izik Eidus (ieidus@redhat.com) wrote:
    > But why not go go step by step?
    > We can first start with this ioctl interface, later when we add swapping
    > to the pages, we can have madvice, and still (probably easily) support
    > the ioctls by just calling from inside ksm the madvice functions for
    > that specific address)

    Then we have 2 interfaces to maintain. Makes more sense to try and get
    it right the first time.

    > I want to see ksm use madvice, but i believe it require some more
    > changes to mm/*.c, so it probably better to start with merging it when
    > it doesnt touch alot of stuff outisde ksm.c, and then to add swapping
    > and after that add madvice support (when the pages are swappable,
    > everyone can use it)

    There's already locking issues w/ using madvise and ksm, so yes,
    changes would need to be made. Some question of how (whether) to handle
    registration of unmapped ranges, closest to say ->mm->def_flags=VM_MERGE.
    My hunch is there's 2 cases users might care about, a specific range
    (qemu-kvm, CERN app, etc) or the entire vma space of a process. Another
    question of what to do w/ VM_LOCKED, should that exclude VM_MERGE or
    let user get what asked for?

    thanks,
    -chris


    \
     
     \ /
      Last update: 2009-05-06 18:19    [W:0.024 / U:30.348 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site