lkml.org 
[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] ftrace: add a tracepoint for __raise_softirq_irqoff()
    On Tue, May 05, 2009 at 02:41:32PM +0800, Xiao Guangrong wrote:
    > From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    >
    > This patch is modified from Mathieu Desnoyers' patch. The original patch
    > can be found here:
    > http://marc.info/?l=linux-kernel&m=123791201816245&w=2
    > This tracepoint can trace the time stamp when softirq action is raised.
    >
    > Changelog for v1 -> v2:
    > 1: Use TRACE_EVENT instead of DEFINE_TRACE
    > 2: Move the tracepoint from raise_softirq_irqoff() to
    > __raise_softirq_irqoff()
    >
    > Changelog for v2 -> v3:
    > Move the definition of __raise_softifq_irqoff() to .c file when
    > CONFIG_TRACEPOINTS is enabled, to avoid recursive includes
    >
    > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    > Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
    >

    hi,

    Could you please add 'docbook' style comments above TRACE_EVENTi()? We
    recently added a tracepoint docbook to the -tip and it already contains
    an 'irq' chapter, so you just need to add the comments for the raise
    softirq tracepoint. Please see:

    http://marc.info/?l=linux-kernel&m=124118471411710&w=2

    thanks,

    -Jason




    \
     
     \ /
      Last update: 2009-05-06 15:53    [W:0.032 / U:209.388 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site