Messages in this thread |  | | | Date | Tue, 5 May 2009 10:25:45 +0200 | | From | Nick Piggin <> | | Subject | Re: [PATCH] SLQB: Coding style cleanups |
| |
On Sun, May 03, 2009 at 03:15:10PM +0300, Pekka Enberg wrote: > From: Pekka Enberg <penberg@cs.helsinki.fi> > > This patch cleans up SQLB to make the code checkpatch clean.
Thanks!
> > Cc: Nick Piggin <npiggin@suse.de> > Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> > --- > mm/slqb.c | 21 ++++++++++++--------- > 1 files changed, 12 insertions(+), 9 deletions(-) > > diff --git a/mm/slqb.c b/mm/slqb.c > index f538f2c..44a91c0 100644 > --- a/mm/slqb.c > +++ b/mm/slqb.c > @@ -59,7 +59,7 @@ static inline void struct_slqb_page_wrong_size(void) > /* > * slqb_min_order: minimum allocation order for slabs > */ > -static int slqb_min_order = 0; > +static int slqb_min_order;
I actually like explicit zero initializers. I think it has been a long time since this actually saved any memory with gcc.
Yes yes, I know that anybody who can "read C" will read the implicit zero initializer anyway... however I just think it is a stupid thing for checkpatch to warn against.
|  |