Messages in this thread | | | Date | Tue, 5 May 2009 08:37:16 +0200 | From | Jiri Pirko <> | Subject | Re: [PATCH] net: introduce a list of device addresses dev_addr_list (v5) |
| |
Tue, May 05, 2009 at 06:37:30AM CEST, davem@davemloft.net wrote: >From: Jiri Pirko <jpirko@redhat.com> >Date: Mon, 4 May 2009 13:14:18 +0200 > >> +static void __hw_addr_del_multiple(struct list_head *to_list, >> + struct list_head *from_list, >> + int addr_len, unsigned char addr_type) >> +{ >> + __hw_addr_del_multiple_ii(to_list, from_list, addr_len, addr_type, -1); >> +} > >Unused static function, this will create build warnings. > >Or, it should :-)
I'm aware. > >If you plan to use such a function in subsequent patches, add >it in those changes not here.
Yes, Ok, I was not quite sure. Thanks for explanation, I'll resubmit later today. > >Otherwise I have no fundamental objection to this patch, nice >work!
| |