Messages in this thread | | | Date | Tue, 5 May 2009 11:33:05 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [patch 7/7] oom: prevent possible OOM_DISABLE livelock |
| |
On Tue, 5 May 2009, Nick Piggin wrote:
> On Mon, May 04, 2009 at 05:27:07PM -0700, David Rientjes wrote: > > It is currently possible to livelock the oom killer if a task is chosen > > for oom kill and another thread sharing the same memory has an oom_adj > > value of OOM_DISABLE. This occurs because oom_kill_task() repeatedly > > Hmm, but didn't the last patch make it a per-mm value? >
Yes, but this avoids taking task_lock(p) in select_bad_process() and moves all locking to badness(). It also introduces new behavior that anything with a badness score of 0 won't be killed, which wasn't explicit before (we relied on oom_kill_task() to reject it).
| |