Messages in this thread | | | From | Hannes Hering <> | Subject | Re: [PATCH 2.6.30-rc5] ehea: fix invalid pointer access | Date | Tue, 5 May 2009 15:45:05 +0200 |
| |
On Tuesday 05 May 2009 14:19:54 David Howells wrote: > In that case, you might want to move the prefetchw() calls in the following: > > pref = skb_array[x]; > - prefetchw(pref); > - prefetchw(pref + EHEA_CACHE_LINE); > + if (pref) { > + prefetchw(pref); > + prefetchw(pref + EHEA_CACHE_LINE); > > to before the if-statement. That way the CPU can be attempting the prefetch > whilst it's chewing over the test and branch. prefetching shouldn't fault on > a bad address. > > David Hi David,
you are right so far, but actually the prefetch calls on POWER also contain an if statement to check if the address is valid (i. e. non-zero). We never have the case that the pref != NULL and pref->data == NULL. And the situation of pref==NULL is very rare. This means there is no benefit moving our if statement down from performance perspective if we assume that our if does not take longer then the if in the prefetch command. We can add an if(likely(pref) if you like. In fact doing the if statement as we do it now we actually save the prefetch if statements in case we hit the situation of pref==NULL.
Regards
Hannes
| |