Messages in this thread | | | Date | Tue, 5 May 2009 14:32:40 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH][RESEND]Documentation/rbtree.txt: cleanup kerneldoc of rbtree.txt |
| |
On Fri, 17 Apr 2009, figo.zhang wrote:
> The first formal parameter of the rb_link_node() is a pointer, and the > "node" is define a data struct (pls see line 67 and line 73 in the > doc), so the actual parameter should use "&data->node". > > Signed-off-by: Figo.zhang <figo.zhang@kolorific.com> > --- > Documentation/rbtree.txt | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/rbtree.txt b/Documentation/rbtree.txt > index 7224459..7710214 100644 > --- a/Documentation/rbtree.txt > +++ b/Documentation/rbtree.txt > @@ -131,8 +131,8 @@ Example: > } > > /* Add new node and rebalance tree. */ > - rb_link_node(data->node, parent, new); > - rb_insert_color(data->node, root); > + rb_link_node(&data->node, parent, new); > + rb_insert_color(&data->node, root); > > return TRUE; > } > @@ -146,10 +146,10 @@ To remove an existing node from a tree, call: > > Example: > > - struct mytype *data = mysearch(mytree, "walrus"); > + struct mytype *data = mysearch(&mytree, "walrus"); > > if (data) { > - rb_erase(data->node, mytree); > + rb_erase(&data->node, &mytree); > myfree(data); > } >
Didn't find it in today's linux-next pileup, so I have applied it to trivial tree. Thanks,
-- Jiri Kosina SUSE Labs
| |