Messages in this thread Patch in this message | | | From | Harry Ciao <> | Subject | [PATCH 1/1] EDAC: CPC925 MC check fixup | Date | Tue, 5 May 2009 11:45:48 +0800 |
| |
Fix an obvious bug in CPC925 Memory Controller's check routine - edac_mc_handle_ue() should have been called for UECC errors and edac_mc_handle_ce() for CECC errors.
Signed-off-by: Harry Ciao <qingtao.cao@windriver.com> --- drivers/edac/cpc925_edac.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/edac/cpc925_edac.c b/drivers/edac/cpc925_edac.c index 2ad6465..8c54196 100644 --- a/drivers/edac/cpc925_edac.c +++ b/drivers/edac/cpc925_edac.c @@ -544,17 +544,16 @@ static void cpc925_mc_check(struct mem_ctl_info *mci) /* Revert column/row addresses into page frame number, etc */ cpc925_mc_get_pfn(mci, mear, &pfn, &offset, &csrow); - if (apiexcp & UECC_EXCP_DETECTED) { - cpc925_mc_printk(mci, KERN_INFO, "DRAM UECC Fault\n"); + if (apiexcp & CECC_EXCP_DETECTED) { + cpc925_mc_printk(mci, KERN_INFO, "DRAM CECC Fault\n"); channel = cpc925_mc_find_channel(mci, syndrome); edac_mc_handle_ce(mci, pfn, offset, syndrome, csrow, channel, mci->ctl_name); } - if (apiexcp & CECC_EXCP_DETECTED) { - cpc925_mc_printk(mci, KERN_INFO, "DRAM CECC Fault\n"); - edac_mc_handle_ue(mci, pfn, offset, - csrow, mci->ctl_name); + if (apiexcp & UECC_EXCP_DETECTED) { + cpc925_mc_printk(mci, KERN_INFO, "DRAM UECC Fault\n"); + edac_mc_handle_ue(mci, pfn, offset, csrow, mci->ctl_name); } cpc925_mc_printk(mci, KERN_INFO, "Dump registers:\n"); -- 1.5.6.2
| |