| Date | Mon, 04 May 2009 20:36:14 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH 13/21] amd64_edac: add f10-and-later methods-p3 |
| |
Borislav Petkov escreveu: > From: Doug Thompson <dougthompson@xmission.com> > > Signed-off-by: Doug Thompson <dougthompson@xmission.com> > Signed-off-by: Borislav Petkov <borislav.petkov@amd.com> > --- > drivers/edac/amd64_edac.c | 318 +++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 318 insertions(+), 0 deletions(-) > > diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c > index fe2342c..84075c0 100644 > --- a/drivers/edac/amd64_edac.c > +++ b/drivers/edac/amd64_edac.c > @@ -2726,4 +2726,322 @@ static int f10_lookup_addr_in_dct(u32 InputAddr, u32 NodeID, u32 ChannelSelect) > return CSFound; > } > > +/* > + * f10_match_to_this_node > + * > + * For a given 'DramRange' value, check if 'SystemAddr' fall within this value > + */ > +static int f10_match_to_this_node(struct amd64_pvt *pvt, int DramRange, > + u64 SystemAddr, > + int *node_id, > + int *channel_select) > +{ > + int CSFound = -1; >
As in the previous patch, please use a standard error code, instead of -1.
> +static int f10_translate_sysaddr_to_CS(struct amd64_pvt *pvt, > + u64 SysAddr, > + int *node, > + int *chanSel) > +{ > + int DramRange; > + int CSFound = -1; > Same here.
Cheers, Mauro
|