lkml.org 
[lkml]   [2009]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: &&/|| typo?
On Sat, 02 May 2009 22:46:47 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:

> Subject: [PATCH] staging: &&/|| typo?

nit: if/when this driver gets moved out of staging/, it will still have
a commit titled "staging: &&/|| typo?" in its record.

That title will be pretty useless and meaningless for a driver which
isn't in staging!

So I'd suggest that in general, the "staging" information be included
inside [], so it gets tossed away as the patch is applied.

Also, the title is pretty bad in other ways - it doesn't identify what
part of the kernel is being changed. At least, not with sufficient
specificity.


So a better title would be, say,

[patch] [staging] wis-sony-tuner.c: fix &&/|| error




\
 
 \ /
  Last update: 2009-05-05 01:09    [W:0.035 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site