lkml.org 
[lkml]   [2009]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] of_serial: remove driver_data direct access of struct device
    From: Greg Kroah-Hartman <gregkh@suse.de>

    In the near future, the driver core is going to not allow direct access
    to the driver_data pointer in struct device. Instead, the functions
    dev_get_drvdata() and dev_set_drvdata() should be used. These functions
    have been around since the beginning, so are backwards compatible with
    all older kernel versions.

    Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Stephen Rothwell <sfr@canb.auug.org.au>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Matthias Fuchs <mfuchs@ma-fu.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/serial/of_serial.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/serial/of_serial.c
    +++ b/drivers/serial/of_serial.c
    @@ -122,7 +122,7 @@ static int __devinit of_platform_serial_

    info->type = port_type;
    info->line = ret;
    - ofdev->dev.driver_data = info;
    + dev_set_drvdata(&ofdev->dev, info);
    return 0;
    out:
    kfree(info);
    @@ -135,7 +135,7 @@ out:
    */
    static int of_platform_serial_remove(struct of_device *ofdev)
    {
    - struct of_serial_info *info = ofdev->dev.driver_data;
    + struct of_serial_info *info = dev_get_drvdata(&ofdev->dev);
    switch (info->type) {
    #ifdef CONFIG_SERIAL_8250
    case PORT_8250 ... PORT_MAX_8250:

    \
     
     \ /
      Last update: 2009-05-04 22:29    [W:0.024 / U:0.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site