lkml.org 
[lkml]   [2009]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] TXx9: Add TX4939 RNG support
    From
    : This is a reply for comments from Matt Mackall via mm-commit mail.

    On Fri, 29 May 2009 19:21:22 -0500, Matt Mackall <mpm@selenic.com> wrote:
    > > +++ a/arch/mips/txx9/generic/setup_tx4939.c
    > > @@ -494,6 +494,24 @@ void __init tx4939_aclc_init(void)
    > > TXX9_IRQ_BASE + TX4939_IR_ACLC, 1, 0, 1);
    > > }
    > >
    > > +#define TX4939_RNG_REG ((TX4939_CRYPTO_REG & 0xfffffffffULL) + 0xb0)
    >
    > This isn't the best place for this define?

    Well, I can move it to include/asm/txx9/tx4939.h.

    > > +++ a/arch/mips/txx9/rbtx4939/setup.c
    > > @@ -501,6 +501,7 @@ static void __init rbtx4939_device_init(
    > > tx4939_dmac_init(0, 2);
    > > tx4939_aclc_init();
    > > platform_device_register_simple("txx9aclc-generic", -1, NULL, 0);
    > > + tx4939_rng_init();
    > > }
    > >
    > > static void __init rbtx4939_setup(void)
    >
    > Not clear to me how this works when this is a module?

    This patch add a registration of a platform device for RNG to vmlinux.
    And the other patch add a driver module for the RNG. This strategy is
    fairly common for SoCs or embedded platforms.

    ---
    Atsushi Nemoto


    \
     
     \ /
      Last update: 2009-05-31 19:01    [W:0.021 / U:29.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site