lkml.org 
[lkml]   [2009]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] coredump: Retry writes where appropriate
    On Sun, May 31, 2009 at 11:18:51AM +0100, Alan Cox wrote:
    > On Sun, 31 May 2009 01:33:39 -0400
    > Paul Smith <paul@mad-scientist.net> wrote:
    >
    > > coredump: Retry writes where appropriate
    > >
    > > Core dump write operations (especially to a pipe) can be incomplete due
    > > to signal reception or possibly recoverable partial writes.
    >
    > NAK this
    >
    > > Previously any incomplete write in the ELF core dumper caused the core
    > > dump to stop, giving short cores in these cases. Modify the core dumper
    > > to retry the write where appropriate.
    >
    > The existing behaviour is an absolute godsend when you've something like
    > a core dump stuck on an NFS mount or something trying to core dump to
    > very slow media.
    >
    > In fact the signals checks were *purposefully added* some time ago.

    Perhaps removing the "|| r == -EINTR" part would make both of you
    happy? He gets the reliability on pipes, you keep the interrupt on
    signals.

    OG.


    \
     
     \ /
      Last update: 2009-05-31 16:07    [W:0.024 / U:30.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site