lkml.org 
[lkml]   [2009]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH -tip] x86: uv - prevent NULL dereference in uv_system_init
    From
    Hi David,

    On Sun, May 3, 2009 at 12:09 PM, David Rientjes <rientjes@google.com> wrote:
    > SLUB stores two new slab allocation orders: the cache's adjustable order
    > which is calculated at kmem_cache_create(), and the smallest order that
    > can accommodate at least one object allocation.  The latter is used as a
    > fallback when the former fails in the page allocator.
    >
    > So for __GFP_PANIC to work in this case, it could not be implemented in
    > the page allocator (SLUB also passes __GFP_NORETRY for new slabs) but
    > rather above it in allocate_slab().  It would then be a no-op for
    > alloc_pages().

    It's probably better to implement __GFP_PANIC in alloc_pages() because
    of kmalloc_large(). You can easily mask the __GFP_PANIC from the first
    call to alloc_slab_page() where we use __GFP_NOWARN to suppress
    out-of-memory warnings.

    But anyway, enough talk, show me the patch! :-)

    Pekka
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-05-03 12:01    [W:4.256 / U:0.948 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site