lkml.org 
[lkml]   [2009]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 11/26] sysfs: Simplify iattr assignments
    From: Eric W. Biederman <ebiederm@xmission.com>

    The granularity of sysfs time when we keep it is 1 ns. Which
    when passed to timestamp_trunc results in a nop. So remove
    the unnecessary function call making sysfs_setattr slightly
    easier to read.

    Acked-by: Tejun Heo <tj@kernel.org>
    Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
    ---
    fs/sysfs/inode.c | 9 +++------
    1 files changed, 3 insertions(+), 6 deletions(-)

    diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
    index 70ff2a2..5020a1d 100644
    --- a/fs/sysfs/inode.c
    +++ b/fs/sysfs/inode.c
    @@ -96,14 +96,11 @@ int sysfs_setattr(struct dentry * dentry, struct iattr * iattr)
    if (ia_valid & ATTR_GID)
    sd_iattr->ia_gid = iattr->ia_gid;
    if (ia_valid & ATTR_ATIME)
    - sd_iattr->ia_atime = timespec_trunc(iattr->ia_atime,
    - inode->i_sb->s_time_gran);
    + sd_iattr->ia_atime = iattr->ia_atime;
    if (ia_valid & ATTR_MTIME)
    - sd_iattr->ia_mtime = timespec_trunc(iattr->ia_mtime,
    - inode->i_sb->s_time_gran);
    + sd_iattr->ia_mtime = iattr->ia_mtime;
    if (ia_valid & ATTR_CTIME)
    - sd_iattr->ia_ctime = timespec_trunc(iattr->ia_ctime,
    - inode->i_sb->s_time_gran);
    + sd_iattr->ia_ctime = iattr->ia_ctime;
    if (ia_valid & ATTR_MODE)
    sd_iattr->ia_mode = iattr->ia_mode;

    --
    1.6.3.1.54.g99dd.dirty


    \
     
     \ /
      Last update: 2009-05-29 22:25    [W:0.029 / U:159.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site