Messages in this thread | | | From | Jarod Wilson <> | Subject | Re: [PATCH 2/2 -tip] drm/i915: intel_lvds.c fix section mismatch warning | Date | Thu, 28 May 2009 11:00:20 -0400 |
| |
On Wednesday 20 May 2009 02:27:35 Jaswinder Singh Rajput wrote: > > intel_no_lvds[] does not require __initdata as it is used only by : > > void intel_lvds_init(struct drm_device *dev) > > fixes section mismatch warning: > > WARNING: drivers/gpu/drm/i915/i915.o(.text+0xf3c5): Section mismatch in reference from the function intel_lvds_init() to the variable .init.data:intel_no_lvds > The function intel_lvds_init() references > the variable __initdata intel_no_lvds. > This is often because intel_lvds_init lacks a __initdata
This would seem to suggest __initdata should be added to intel_lvds_init, rather than removed from intel_no_lvds...
But I suppose either one would work. Apologies for not catching the initial mismatch... :\
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> > --- > drivers/gpu/drm/i915/intel_lvds.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c > index 439a865..5ffadf9 100644 > --- a/drivers/gpu/drm/i915/intel_lvds.c > +++ b/drivers/gpu/drm/i915/intel_lvds.c > @@ -391,7 +391,7 @@ static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id) > } > > /* These systems claim to have LVDS, but really don't */ > -static const struct dmi_system_id __initdata intel_no_lvds[] = { > +static const struct dmi_system_id intel_no_lvds[] = { > { > .callback = intel_no_lvds_dmi_callback, > .ident = "Apple Mac Mini (Core series)",
-- Jarod Wilson jarod@redhat.com
| |