lkml.org 
[lkml]   [2009]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] Time out for possible dead loops during queued invalidation wait
>> Which error code is better? Is EAGAIN ok?
>
>That depends on driver details - probably EIO would be suitable, dunno.
>
>But all the callers of qi_submit_sync() seem to just drop the error
>code on the floor:
>
> /* should never fail */
> qi_submit_sync(&desc, iommu);
>
>and may well cause a kernel crash as a result.

Should the code go to kernel panic after timeout in qi_submit_sync() loops? When timeout (10 seconds) in the loops, something in hardware could be wrong.

Thanks.

-Fenghua


\
 
 \ /
  Last update: 2009-05-28 01:29    [W:0.161 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site