Messages in this thread | | | From | "Yu, Fenghua" <> | Date | Wed, 27 May 2009 16:25:52 -0700 | Subject | RE: [PATCH] Time out for possible dead loops during queued invalidation wait |
| |
>> Which error code is better? Is EAGAIN ok? > >That depends on driver details - probably EIO would be suitable, dunno. > >But all the callers of qi_submit_sync() seem to just drop the error >code on the floor: > > /* should never fail */ > qi_submit_sync(&desc, iommu); > >and may well cause a kernel crash as a result.
Should the code go to kernel panic after timeout in qi_submit_sync() loops? When timeout (10 seconds) in the loops, something in hardware could be wrong.
Thanks.
-Fenghua
| |