lkml.org 
[lkml]   [2009]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] S3C: beyond ARRAY_SIZE of s3c_gpios
On Wed, 20 May 2009 17:51:07 +0200 Roel Kluin <roel.kluin@gmail.com> wrote:

> Do not go beyond ARRAY_SIZE of s3c_gpios
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/arch/arm/plat-s3c/gpio.c b/arch/arm/plat-s3c/gpio.c
> index d71dd6d..29926c1 100644
> --- a/arch/arm/plat-s3c/gpio.c
> +++ b/arch/arm/plat-s3c/gpio.c
> @@ -28,7 +28,7 @@ static __init void s3c_gpiolib_track(struct s3c_gpio_chip *chip)
>
> gpn = chip->chip.base;
> for (i = 0; i < chip->chip.ngpio; i++, gpn++) {
> - BUG_ON(gpn > ARRAY_SIZE(s3c_gpios));
> + BUG_ON(gpn >= ARRAY_SIZE(s3c_gpios));
> s3c_gpios[gpn] = chip;
> }
> }

umm, OK, but the title and changelog are quite inaccurate.

I rewrote the title to

s3c: fix check of index into s3c_gpios[]

and rewrote the changelog to

The check of the s3c_gpios[] index had an off-by-one.



\
 
 \ /
  Last update: 2009-05-27 08:01    [W:0.958 / U:1.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site