lkml.org 
[lkml]   [2009]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/11] ntfs: remove old debug check for dirty data in ntfs_put_super()
    Date
    This should not trigger anymore, so kill it.

    Acked-by: Anton Altaparmakov <aia21@cam.ac.uk>
    Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
    ---
    fs/ntfs/super.c | 33 +++------------------------------
    1 files changed, 3 insertions(+), 30 deletions(-)

    diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
    index f76951d..3fc03bd 100644
    --- a/fs/ntfs/super.c
    +++ b/fs/ntfs/super.c
    @@ -2373,39 +2373,12 @@ static void ntfs_put_super(struct super_block *sb)
    vol->mftmirr_ino = NULL;
    }
    /*
    - * If any dirty inodes are left, throw away all mft data page cache
    - * pages to allow a clean umount. This should never happen any more
    - * due to mft.c::ntfs_mft_writepage() cleaning all the dirty pages as
    - * the underlying mft records are written out and cleaned. If it does,
    - * happen anyway, we want to know...
    + * We should have no dirty inodes left, due to
    + * mft.c::ntfs_mft_writepage() cleaning all the dirty pages as
    + * the underlying mft records are written out and cleaned.
    */
    ntfs_commit_inode(vol->mft_ino);
    write_inode_now(vol->mft_ino, 1);
    - if (sb_has_dirty_inodes(sb)) {
    - const char *s1, *s2;
    -
    - mutex_lock(&vol->mft_ino->i_mutex);
    - truncate_inode_pages(vol->mft_ino->i_mapping, 0);
    - mutex_unlock(&vol->mft_ino->i_mutex);
    - write_inode_now(vol->mft_ino, 1);
    - if (sb_has_dirty_inodes(sb)) {
    - static const char *_s1 = "inodes";
    - static const char *_s2 = "";
    - s1 = _s1;
    - s2 = _s2;
    - } else {
    - static const char *_s1 = "mft pages";
    - static const char *_s2 = "They have been thrown "
    - "away. ";
    - s1 = _s1;
    - s2 = _s2;
    - }
    - ntfs_error(sb, "Dirty %s found at umount time. %sYou should "
    - "run chkdsk. Please email "
    - "linux-ntfs-dev@lists.sourceforge.net and say "
    - "that you saw this message. Thank you.", s1,
    - s2);
    - }
    #endif /* NTFS_RW */

    iput(vol->mft_ino);
    --
    1.6.3.rc0.1.gf800


    \
     
     \ /
      Last update: 2009-05-27 11:45    [W:0.045 / U:0.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site