Messages in this thread Patch in this message | | | Date | Wed, 27 May 2009 11:04:48 +0800 | From | Li Zefan <> | Subject | [PATCH 2/3] tracing/stat: remember to free root node |
| |
When closing a trace_stat file, we destroy the rbtree constructed during file open, but there is memory leak that the root node is not freed.
[ Impact: fix memory leak when closing a trace_stat file ]
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- kernel/trace/trace_stat.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c index 8b7420a..a80d947 100644 --- a/kernel/trace/trace_stat.c +++ b/kernel/trace/trace_stat.c @@ -60,8 +60,8 @@ static struct rb_node *release_next(struct rb_node *node) return node->rb_right; else { if (!parent) - return NULL; - if (parent->rb_left == node) + ; + else if (parent->rb_left == node) parent->rb_left = NULL; else parent->rb_right = NULL; -- 1.5.4.rc3
| |