Messages in this thread | | | Date | Wed, 27 May 2009 09:27:01 +1000 | From | David McCullough <> | Subject | Re: [uClinux-dev] Re: [PATCH 2/2] mtd/maps: uclinux: support Blackfin systems |
| |
Jivin Paul Mundt lays it down ... > On Tue, May 26, 2009 at 01:24:46PM -0400, Mike Frysinger wrote: > > On Tue, May 26, 2009 at 13:06, Paul Mundt wrote: > > > Use the attached, and then just set uclinux_ram_map.phys = your_address_here > > > in your setup_arch(). Having weak symbols in drivers that are supposed to > > > be overriden by the architecture code is just way too backwards for > > > words. Globals suffice fine for this sort of thing, if you are not going > > > to go to the effort to pass this information to the driver directly that > > > is. > > > > i was thinking something else, but obviously this is nicer than what i > > was thinking > > Unfortunately there is the problem that the map driver itself is a > tristate, so if this is built as a module, the symbol will not be > available to you. On the other hand, if it doesn't need to ever really be > a module, converting it to a bool ought to be workable. There are no > in-tree users that enable this as a module anyways.
Based on how it relocates the rootfs, I don't believe a module can ever be work, so a boolean would be a better choice IMO,
Cheers, Davidm
-- David McCullough, david_mccullough@securecomputing.com, Ph:+61 734352815 McAfee - SnapGear http://www.snapgear.com http://www.uCdot.org
| |