Messages in this thread | | | Date | Tue, 26 May 2009 15:16:21 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 001/001] gpio: AMD CS5535/CS5536 GPIO driver |
| |
On Sat, 23 May 2009 13:53:58 +0200 Tobias M__ller <Tobias_Mueller@twam.info> wrote:
> From: Tobias Mueller <Tobias_Mueller@twam.info> > > A GPIO driver for AMD Geode Companion Device CS5535/CS5536 > using the GPIO framework as a replacement for old cs5535-gpio driver.
It looks reasonsable from a quick scan.
The patch was somewhat wordwrapped by your email client.
The patch generates a large number of warnings when checked with scripts/checkpatch.pl. Please take a look at that and permanently incorporate checkpatch into your patch generation tools.
Please cc the following individuals on future versions of this patch:
David Brownell <david-b@pacbell.net> Jordan Crouse <jordan@cosmicpenguin.net> Ben Gardner <gardner.ben@gmail.com>
> index edb0253..0b7ef6f 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -67,6 +67,14 @@ config GPIO_SYSFS > > comment "Memory mapped GPIO expanders:" > > +config GPIO_CS5535 > + tristate "AMD CS5535/CS5536 (Geode Companion Device)" > + depends on !CONFIG_CS5535_GPIO && X86 && EXPERIMENTAL > + default N > + help > + Say yes here to support GPIO pins of AMD CS5535/CS5536 > + (Geode Companion Device)
We'll need to discuss the migration plan - we don't want to maintain two drivers for the same thing.
| |