Messages in this thread |  | | | Date | Tue, 26 May 2009 13:41:34 -0700 | | From | Andrew Morton <> | | Subject | Re: [PATCH][mmtom] clean up once printk routine |
| |
On Tue, 26 May 2009 15:59:43 +0900 Minchan Kim <minchan.kim@gmail.com> wrote:
> On Tue, 26 May 2009 15:52:32 +0900 (JST) > KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > > > > == CUT HERE == > > > > > > There are some places to be able to use printk_once instead of hard coding. > > > > > > It will help code readability and maintenance. > > > This patch doesn't change function's behavior. > > > > > > Signed-off-by: Minchan Kim <minchan.kim@gmail.com> > > > CC: Dominik Brodowski <linux@dominikbrodowski.net> > > > CC: David S. Miller <davem@davemloft.net> > > > CC: Ingo Molnar <mingo@elte.hu> > > > --- > > > arch/x86/kernel/cpu/common.c | 8 ++------ > > > drivers/net/3c515.c | 7 ++----- > > > drivers/pcmcia/pcmcia_ioctl.c | 9 +++------ > > > 3 files changed, 7 insertions(+), 17 deletions(-) > > > > Please separete to three patches ;) > > After I listen about things I missed, I will repost it at all once with each patch.
Yes, that would be better. But for a trivial little patch like this I expect we can just merge it and move on. But please do split up these multi-subsystem patches in future.
|  |