lkml.org 
[lkml]   [2009]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] firmware: Allocate firmware id dynamically
On Tue, 26 May 2009 16:11:35 +0200
Kay Sievers <kay.sievers@vrfy.org> wrote:

> On Tue, May 26, 2009 at 16:04, Samuel Ortiz <sameo@linux.intel.com> wrote:
>
> > Since the firmware loader is not maintained by anyone, I'm sending this one to
> > you, for the next merge window:
>
> It's part of the driver-core directory, and handled by Greg.

To which it doesn't apply. It needed more fixes than I felt like making.

> > The firmware loader has a statically allocated 30 bytes long string for the
> > firmware id (a.k.a. the firmware file name). There is no reason why we couldnt
> > allocate dynamically, and avoid having restrictions on the firmware names
> > lengths.
>
> Looks good.
>
> > Please note that we have to keep the FIRMWARE_NAME_MAX definition around as
> > some drivers rely on it.
>
> I think the 6 files should be converted, and FIRMWARE_NAME_MAX
> removed, otherwise people will keep copying that crap around.
>
> drivers/pcmcia/ds.c
> drivers/usb/atm/ueagle-atm.c
> drivers/net/wireless/libertas/if_usb.c
> drivers/net/wireless/libertas/if_spi.c
> drivers/media/dvb/dvb-usb/dvb-usb.h
> drivers/media/common/tuners/tuner-xc2028.c

Yep.



\
 
 \ /
  Last update: 2009-05-26 22:27    [W:1.369 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site