Messages in this thread | | | Date | Tue, 26 May 2009 14:32:45 -0400 | Subject | Re: [PATCH 4/6] dvb/dvb-usb: prepare for FIRMWARE_NAME_MAX removal | From | Michael Krufky <> |
| |
On Tue, May 26, 2009 at 1:40 PM, Samuel Ortiz <sameo@linux.intel.com> wrote: > From: Samuel Ortiz <sameo@linux.intel.com> > To: Mauro Carvalho Chehab <mchehab@infradead.org> > > We're going to remove the FIRMWARE_NAME_MAX definition in order to avoid any > firmware name length restriction. > This patch changes the dvb_usb_device_properties firmware field accordingly. > > Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> > > --- > drivers/media/dvb/dvb-usb/dvb-usb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: iwm-2.6/drivers/media/dvb/dvb-usb/dvb-usb.h > =================================================================== > --- iwm-2.6.orig/drivers/media/dvb/dvb-usb/dvb-usb.h 2009-05-26 17:24:36.000000000 +0200 > +++ iwm-2.6/drivers/media/dvb/dvb-usb/dvb-usb.h 2009-05-26 17:25:19.000000000 +0200 > @@ -196,7 +196,7 @@ struct dvb_usb_device_properties { > #define CYPRESS_FX2 3 > int usb_ctrl; > int (*download_firmware) (struct usb_device *, const struct firmware *); > - const char firmware[FIRMWARE_NAME_MAX]; > + const char *firmware; > int no_reconnect; > > int size_of_priv; > > -- > Intel Open Source Technology Centre > http://oss.intel.com/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
Samuel,
Your patch makes the following change:
- const char firmware[FIRMWARE_NAME_MAX]; + const char *firmware;
Before your change, struct dvb_usb_device_properties actually contains memory allocated for the firmware filename. After your change, this is nothing but a pointer.
This will cause an OOPS.
Regards,
Mike Krufky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |