Messages in this thread | | | From | Michael Buesch <> | Subject | Re: [PATCH 2.6.30-rc4] r8169: avoid losing MSI interrupts | Date | Tue, 26 May 2009 20:22:23 +0200 |
| |
On Tuesday 26 May 2009 07:55:03 David Miller wrote: > From: David Dillow <dave@thedillows.org> > Date: Fri, 22 May 2009 21:29:34 -0400 > > > The 8169 chip only generates MSI interrupts when all enabled event > > sources are quiescent and one or more sources transition to active. If > > not all of the active events are acknowledged, or a new event becomes > > active while the existing ones are cleared in the handler, we will not > > see a new interrupt. > > > > The current interrupt handler masks off the Rx and Tx events once the > > NAPI handler has been scheduled, which opens a race window in which we > > can get another Rx or Tx event and never ACK'ing it, stopping all > > activity until the link is reset (ifconfig down/up). Fix this by always > > ACK'ing all event sources, and loop in the handler until we have all > > sources quiescent. > > > > Signed-off-by: David Dillow <dave@thedillows.org> > > I've applied this, thanks David. > >
I didn't notice a CC:stable. I think this should also go to stable. Does somebody take care?
(wiggle is able to apply the patch to stable without any problems, so it's easy to do a patch)
-- Greetings, Michael.
| |