Messages in this thread | | | Date | Tue, 26 May 2009 13:24:46 -0400 | Subject | Re: [PATCH 2/2] mtd/maps: uclinux: support Blackfin systems | From | Mike Frysinger <> |
| |
On Tue, May 26, 2009 at 13:06, Paul Mundt wrote: > On Tue, May 26, 2009 at 12:50:51PM -0400, Mike Frysinger wrote: >> On Tue, May 26, 2009 at 12:47, Paul Mundt wrote: >> > On Tue, May 26, 2009 at 12:42:48PM -0400, Mike Frysinger wrote: >> >> > In this case you should just kill all of that crap off, and have the >> >> > platforms that use this set uclinux_ram_map up themselves, it's already >> >> > a global. Of course you can use _ebss as a default value for >> >> > uclinux_ram_map.phys and just override it in your platform. >> >> >> >> i would agree if it were a board-specific issue, but it's an arch >> >> issue, so pushing it to the boards level is wrong. ??i can however >> >> replace the addr with a global weak and add a symbol into the Blackfin >> >> arch code to override it. >> >> >> > I obviously meant architectures setting up the address, not the board >> > code, as this has nothing at all to do with boards. There are already >> > plenty of cases in setup_arch() for filling in uclinux mtd data, one more >> > isn't going to make a difference. >> > >> > I don't see anything wrong with keeping uclinux_ram_map as a global >> > however, particularly since platforms that need to special case the >> > mapping can easily do this under the existing ifdef. Adding weak symbols >> > for something like this just seems silly. >> >> the point of the weak symbol was so that the map could provide a sane >> default that works for most everyone out there without having to copy >> & paste the same code to every arch, and to make new arch porters >> worry about what needs to be done to use this very trivial map > > Did you purposely only read the parts of my email that you felt like? > Note the original quoted part that mentions using _ebss as a default and > simply overriding it in your platform.
if i wanted to piss you off, i imagine that would be what i was doing. but considering my purpose is to get merged, there's a more logical conclusion. we envisioned different solutions, so having the ideas in our minds not line up isnt terribly surprising.
> Use the attached, and then just set uclinux_ram_map.phys = your_address_here > in your setup_arch(). Having weak symbols in drivers that are supposed to > be overriden by the architecture code is just way too backwards for > words. Globals suffice fine for this sort of thing, if you are not going > to go to the effort to pass this information to the driver directly that > is.
i was thinking something else, but obviously this is nicer than what i was thinking -mike
| |