lkml.org 
[lkml]   [2009]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mtd/maps: uclinux: support Blackfin systems
On Tue, May 26, 2009 at 05:46:31AM -0400, Mike Frysinger wrote:
> diff --git a/drivers/mtd/maps/uclinux.c b/drivers/mtd/maps/uclinux.c
> index 57699c2..dcb552f 100644
> --- a/drivers/mtd/maps/uclinux.c
> +++ b/drivers/mtd/maps/uclinux.c
> @@ -55,8 +55,13 @@ static int __init uclinux_mtd_init(void)
> {
> struct mtd_info *mtd;
> struct map_info *mapp;
> +#ifdef CONFIG_BLACKFIN
> + extern unsigned long memory_mtd_start;
> + unsigned long addr = (unsigned long) memory_mtd_start;
> +#else
> extern char _ebss;
> unsigned long addr = (unsigned long) &_ebss;
> +#endif
>
> mapp = &uclinux_ram_map;
> mapp->phys = addr;

NAK.

I know there's no accounting for taste, but it would be nice to at least
see some minimal amount of effort going in to fixing these things
sanely rather than just lazily shoving ifdefs in wherever possible.

In this case you should just kill all of that crap off, and have the
platforms that use this set uclinux_ram_map up themselves, it's already
a global. Of course you can use _ebss as a default value for
uclinux_ram_map.phys and just override it in your platform.


\
 
 \ /
  Last update: 2009-05-26 13:35    [from the cache]
©2003-2011 Jasper Spaans