lkml.org 
[lkml]   [2009]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/13] libata: get rid of ATA_MAX_QUEUE loop in ata_qc_complete_multiple()
    Date
    We very rarely (if ever) complete more than one command in the
    sactive mask at the time, even for extremely high IO rates. So
    looping over the entire range of possible tags is pointless,
    instead use __ffs() to just find the completed tags directly.

    Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
    ---
    drivers/ata/libata-core.c | 11 +++++------
    1 files changed, 5 insertions(+), 6 deletions(-)

    diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
    index c924230..ca4d208 100644
    --- a/drivers/ata/libata-core.c
    +++ b/drivers/ata/libata-core.c
    @@ -5031,7 +5031,6 @@ int ata_qc_complete_multiple(struct ata_port *ap, u32 qc_active)
    {
    int nr_done = 0;
    u32 done_mask;
    - int i;

    done_mask = ap->qc_active ^ qc_active;

    @@ -5041,16 +5040,16 @@ int ata_qc_complete_multiple(struct ata_port *ap, u32 qc_active)
    return -EINVAL;
    }

    - for (i = 0; i < ATA_MAX_QUEUE; i++) {
    + while (done_mask) {
    struct ata_queued_cmd *qc;
    + unsigned int tag = __ffs(done_mask);

    - if (!(done_mask & (1 << i)))
    - continue;
    -
    - if ((qc = ata_qc_from_tag(ap, i))) {
    + qc = ata_qc_from_tag(ap, tag);
    + if (qc) {
    ata_qc_complete(qc);
    nr_done++;
    }
    + done_mask &= ~(1 << tag);
    }

    return nr_done;
    --
    1.6.3.rc0.1.gf800


    \
     
     \ /
      Last update: 2009-05-25 09:35    [W:0.024 / U:92.584 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site