Messages in this thread Patch in this message | | | From | Philipp Zabel <> | Subject | [PATCH 4/5] mmc: tmio_mmc: correct probe return value for num_resources != 3 | Date | Mon, 25 May 2009 21:28:00 +0200 |
| |
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com> Cc: Pierre Ossman <pierre@ossman.eu> Cc: Ian Molton <spyro@f2s.com> --- drivers/mmc/host/tmio_mmc.c | 12 +++++------- 1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c index 9a3dc54..b1b4e6c 100644 --- a/drivers/mmc/host/tmio_mmc.c +++ b/drivers/mmc/host/tmio_mmc.c @@ -521,23 +521,21 @@ static int __devinit tmio_mmc_probe(struct platform_device *dev) struct resource *res_ctl, *res_cnf; struct tmio_mmc_host *host; struct mmc_host *mmc; - int ret = -ENOMEM; + int ret = -EINVAL; if (dev->num_resources != 3) goto out; res_ctl = platform_get_resource(dev, IORESOURCE_MEM, 0); res_cnf = platform_get_resource(dev, IORESOURCE_MEM, 1); - if (!res_ctl || !res_cnf) { - ret = -EINVAL; + if (!res_ctl || !res_cnf) goto out; - } pdata = cell->driver_data; - if (!pdata || !pdata->hclk) { - ret = -EINVAL; + if (!pdata || !pdata->hclk) goto out; - } + + ret = -ENOMEM; mmc = mmc_alloc_host(sizeof(struct tmio_mmc_host), &dev->dev); if (!mmc) -- 1.6.3.1
| |