lkml.org 
[lkml]   [2009]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/12] writeback: separate the flushing state/task from the bdi
On Mon, May 25 2009, Jan Kara wrote:
> On Mon 25-05-09 09:34:41, Jens Axboe wrote:
> > Add a struct bdi_writeback for tracking and handling dirty IO. This
> > is in preparation for adding > 1 flusher task per bdi.
> >
> > Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
> ...
> > static int bdi_start_fn(void *ptr)
> > {
> > - struct backing_dev_info *bdi = ptr;
> > + struct bdi_writeback *wb = ptr;
> > + struct backing_dev_info *bdi = wb->bdi;
> > struct task_struct *tsk = current;
> > -
> > - /*
> > - * Add us to the active bdi_list
> > - */
> > - mutex_lock(&bdi_lock);
> > - list_add(&bdi->bdi_list, &bdi_list);
> > - mutex_unlock(&bdi_lock);
> I'm probably missing something but I cannot find where the bdi is added
> to the bdi_list after this patch...

For some reason, that part is now in the following patch. The two hunks
should just be deleted, good catch!

--
Jens Axboe



\
 
 \ /
  Last update: 2009-05-25 12:39    [W:3.225 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site