lkml.org 
[lkml]   [2009]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/7] percpu: clean up percpu variable definitions
Date
On Wed, 20 May 2009 05:07:35 pm Tejun Heo wrote:
> Percpu variable definition is about to be updated such that
>
> * percpu symbols must be unique even the static ones
>
> * in-function static definition is not allowed

That spluttering noise is be choking on the title of this patch :)

Making these pseudo statics is in no way a cleanup. How about we just
say "they can't be static" and do something like:

/* Sorry, can't be static: that breaks archs which need these weak. */
#define DEFINE_PER_CPU(type, var) \
extern typeof(type) var; DEFINE_PER_CPU_SECTION(type, name, "")

Thanks,
Rusty.


\
 
 \ /
  Last update: 2009-05-25 12:31    [W:0.412 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site