Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 3/7] percpu: clean up percpu variable definitions | Date | Mon, 25 May 2009 15:37:34 +0930 |
| |
On Wed, 20 May 2009 05:07:35 pm Tejun Heo wrote: > Percpu variable definition is about to be updated such that > > * percpu symbols must be unique even the static ones > > * in-function static definition is not allowed
That spluttering noise is be choking on the title of this patch :)
Making these pseudo statics is in no way a cleanup. How about we just say "they can't be static" and do something like:
/* Sorry, can't be static: that breaks archs which need these weak. */ #define DEFINE_PER_CPU(type, var) \ extern typeof(type) var; DEFINE_PER_CPU_SECTION(type, name, "")
Thanks, Rusty.
| |