Messages in this thread | | | From | Kay Sievers <> | Date | Sun, 24 May 2009 15:03:31 +0200 | Subject | Re: [PATCH 22/20] sysfs: Make sysfs_rename_link atomic |
| |
On Sun, May 24, 2009 at 01:21, Kay Sievers <kay.sievers@vrfy.org> wrote: > On Sat, May 23, 2009 at 23:32, Kay Sievers <kay.sievers@vrfy.org> wrote: >> On Sat, May 23, 2009 at 22:13, Eric W. Biederman <ebiederm@xmission.com> wrote: >>> From: Eric W. Biederman <ebiederm@xmission.com> >>> >>> Use the existing sysfs_rename to make sysfs_rename_link an atomic >>> operation that does less work. While I am at add additional sanity >>> checking to ensure it is a symlink I am renaming. >>> >>> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com> >> >> Looks great, and so much better than the remove and re-create thing. > > Do you have your git tree public somewhere, or do you mind sending me > an all-in-one patch? I like to give it a try here.
Looks good. It survives a heavy hotplug setup just fine, renaming works fine here, and sysfs looks right. There are a bunch of warnings for some non-empty directories, which I replied with in the patch that added the warning.
Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |