Messages in this thread | | | Date | Fri, 22 May 2009 08:01:11 +0100 | From | Al Viro <> | Subject | Re: [PATCH V2 0/3] Introduce and use DO_ONCE statement expression macro |
| |
On Thu, May 21, 2009 at 10:39:16PM -0700, Joe Perches wrote: > On Fri, 2009-05-22 at 06:26 +0100, Al Viro wrote: > > Your DO_ONCE(....) parses as "what the fuck is that?" followed by > > grepping for definition, and the cost is much higher. > > So what do you suggest? > > #define pr_info_once(fmt, args...) printk_once(KERN_INFO pr_fmt(fmt), ##args) > #define pr_warning_once(fmt, args...) printk_once(KERN_WARNING pr_fmt(fmt), ##args) > etc
That would be much saner.
| |