| Date | Fri, 22 May 2009 16:59:24 +0800 | From | Amerigo Wang <> | Subject | Re: [PATCH 04/38] ipcns 2/4: extract create_ipc_ns() |
| |
On Fri, May 22, 2009 at 08:54:58AM +0400, Alexey Dobriyan wrote: >clone_ipc_ns() is misnamed, it doesn't clone anything and doesn't use passed >parameter. Rename it. > >create_ipc_ns() will be used by C/R to create fresh ipcns. > >Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> >Acked-by: Serge Hallyn <serue@us.ibm.com> >--- > ipc/namespace.c | 9 ++------- > 1 files changed, 2 insertions(+), 7 deletions(-) > >diff --git a/ipc/namespace.c b/ipc/namespace.c >index a56fc59..231ee53 100644 >--- a/ipc/namespace.c >+++ b/ipc/namespace.c >@@ -14,7 +14,7 @@ > > #include "util.h" > >-static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns) >+static struct ipc_namespace *create_ipc_ns(void)
Great!! I am wondering why nobody else found this... :)
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
> { > struct ipc_namespace *ns; > int err; >@@ -48,14 +48,9 @@ static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns) > > struct ipc_namespace *copy_ipcs(unsigned long flags, struct ipc_namespace *ns) > { >- struct ipc_namespace *new_ns; >- > if (!(flags & CLONE_NEWIPC)) > return get_ipc_ns(ns); >- >- new_ns = clone_ipc_ns(ns); >- >- return new_ns; >+ return create_ipc_ns(); > } > > /* >-- >1.5.6.5 > >-- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/
|