Messages in this thread |  | | | Date | Thu, 21 May 2009 23:13:33 +0400 | | From | Sergei Shtylyov <> | | Subject | Re: [PATCH 3/4] ide: respect quirk_drives[] list on all controllers |
| |
Bartlomiej Zolnierkiewicz wrote:
> * Add ide_check_nien_quirk_list() helper to the core code > and then use it in ide_port_tune_devices().
> * Remove no longer needed ->quirkproc methods from hpt366.c > and pdc202xx_{new,old}.c.
Haha, I remembered about that idea of yours and was thinking of undertaking its implementation just yesterday. You've beten me to it. :-)
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Index: b/drivers/ide/ide-iops.c > =================================================================== > --- a/drivers/ide/ide-iops.c > +++ b/drivers/ide/ide-iops.c > @@ -269,6 +269,31 @@ no_80w: > return 0; > } > > +static const char *nien_quirk_list[] = { > + "QUANTUM FIREBALLlct08 08", > + "QUANTUM FIREBALLP KA6.4", > + "QUANTUM FIREBALLP KA9.1", > + "QUANTUM FIREBALLP KX13.6", > + "QUANTUM FIREBALLP KX20.5", > + "QUANTUM FIREBALLP KX27.3", > + "QUANTUM FIREBALLP LM20.4", > + "QUANTUM FIREBALLP LM20.5", > + NULL > +}; > + > +void ide_check_nien_quirk_list(ide_drive_t *drive)
Why not reuse ide_in_drive_list()?
> +{ > + const char **list, *m = (char *)&drive->id[ATA_ID_PROD]; > + > + for (list = nien_quirk_list; *list != NULL; list++) > + if (strstr(m, *list) != NULL) {
Ah, strstr() vs strcmp()... I think strcmp() should work anyway...
> + drive->quirk_list = 2; > + return; > + } > + > + drive->quirk_list = 0; > +} > + > int ide_driveid_update(ide_drive_t *drive) > { > u16 *id;
MBR, Sergei
|  |