Messages in this thread |  | | | Date | Thu, 21 May 2009 11:52:05 -0400 | | From | Masami Hiramatsu <> | | Subject | Re: [PATCH -tip v6 1/5] x86: instruction decorder API |
| |
H. Peter Anvin wrote: > Masami Hiramatsu wrote: >>> /usr/bin/env 'awk -f' gen-insn-attr-x86.awk >>> >>> which is obviously wrong. >> Oops, right. Anyway, there is no reason that we make it >> executable because it's always called from Makefile. >> So, I think just removing that line is better way. >> > > I suggest leaving in a #!/bin/awk line just for documentation's sake, > though.
OK, I'd leave that, and change usage line to use awk command instead of run the script directly.
Thank you!
> > -hpa >
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division
e-mail: mhiramat@redhat.com
|  |