Messages in this thread | | | Date | Thu, 21 May 2009 16:29:04 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH] kvm: fix irqfd build failure discovered in linux-next |
| |
Gregory Haskins wrote: >>> EXTRA_CFLAGS += -Ivirt/kvm -Iarch/x86/kvm >>> +EXTRA_CFLAGS += -DKVM_HAVE_EVENTFD >>> >>> >>> >> The standard idiom for this is to use a Kconfig symbol; see for >> example HAVE_KVM_IRQCHIP in arch/*/kvm/Kconfig. >> > > Ah, I didn't realize I could do this in such a contained manner. I was > afraid of polluting the top level arch/Kconfig, which is why I went this > other route. But I see from your example that this is not the case. I > will make a v2 with this change. >
Note the situation is not as good as it could be, as you have to replicate the Kconfig for each arch. One day I'll set up virt/kvm/Kconfig which will set up defaults, so archs can override them.
-- error compiling committee.c: too many arguments to function
| |