lkml.org 
[lkml]   [2009]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/20] sysfs: Simplify sysfs_chmod_file semantics
    Date
    From: Eric W. Biederman <ebiederm@xmission.com>

    Currently every caller of sysfs_chmod_file happens at either
    file creation time to set a non-default mode or in response
    to a specific user requested space change in policy. Making
    timestamps of when the chmod happens and notification of
    a file changing mode uninteresting.

    Remove the unnecessary time stamp and filesystem change
    notification, and removes the last of the explicit inotify
    and donitfy support from sysfs.

    Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
    ---
    fs/sysfs/file.c | 10 +---------
    1 files changed, 1 insertions(+), 9 deletions(-)

    diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
    index b1606e0..0786b41 100644
    --- a/fs/sysfs/file.c
    +++ b/fs/sysfs/file.c
    @@ -602,17 +602,9 @@ int sysfs_chmod_file(struct kobject *kobj, struct attribute *attr, mode_t mode)
    mutex_lock(&inode->i_mutex);

    newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO);
    - newattrs.ia_valid = ATTR_MODE | ATTR_CTIME;
    - newattrs.ia_ctime = current_fs_time(inode->i_sb);
    + newattrs.ia_valid = ATTR_MODE;
    rc = sysfs_setattr(victim, &newattrs);

    - if (rc == 0) {
    - fsnotify_change(victim, newattrs.ia_valid);
    - mutex_lock(&sysfs_mutex);
    - victim_sd->s_mode = newattrs.ia_mode;
    - mutex_unlock(&sysfs_mutex);
    - }
    -
    mutex_unlock(&inode->i_mutex);
    out:
    dput(victim);
    --
    1.6.1.2.350.g88cc


    \
     
     \ /
      Last update: 2009-05-21 02:33    [W:0.033 / U:60.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site